Add SDPA support for M2M100 #33309
Merged
Add SDPA support for M2M100 #33309
+178
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Sep 16, 2024
|
slow runs cc @amyeroberts |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Great - all looks good. @isaac091 could you resolve the conflicts? Once done we should be good to merge |
|
Resolved! Thanks @amyeroberts. |
|
Merging as the failing hub tests are unrelated (also on other PRs, shouldn't be impacted by this PR, looks like connection errors) and slow tests all pass (other than multi-gpu test which also failed for a connection error) |
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 2, 2024
* Add SDPA support for M2M100 * [run_slow] m2m_100, nllb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds SDPA support for M2M100 models.
Part of #28005.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @fxmarty @amyeroberts